Skip to content

chore: generate feature flag files from shared#7361

Merged
dmathieu merged 4 commits intoopen-telemetry:mainfrom
flc1125:x-template
Sep 16, 2025
Merged

chore: generate feature flag files from shared#7361
dmathieu merged 4 commits intoopen-telemetry:mainfrom
flc1125:x-template

Conversation

@flc1125
Copy link
Copy Markdown
Member

@flc1125 flc1125 commented Sep 13, 2025

Given the observed facts, multiple components need to depend on the x package together. To reduce duplication and unify style management, this PR is added.

PS: Currently only go.opentelemetry.io/otel/exporters/stdout/stdouttrace is supported; other components will be supplemented after this PR is merged.

- Replace Observability-specific tests with generic Feature tests
- Add mockFeature for testing purposes
- Update test cases to cover new feature flag behavior
- Remove unused import of "strings" in x.go
@flc1125 flc1125 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 13, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.4%. Comparing base (5b808c6) to head (c9f5c33).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7361   +/-   ##
=====================================
  Coverage   85.4%   85.4%           
=====================================
  Files        268     269    +1     
  Lines      24297   24297           
=====================================
+ Hits       20759   20761    +2     
+ Misses      3161    3159    -2     
  Partials     377     377           
Files with missing lines Coverage Δ
...xporters/stdout/stdouttrace/internal/x/features.go 100.0% <100.0%> (ø)
exporters/stdout/stdouttrace/internal/x/x.go 100.0% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Add copyright notice and Apache 2.0 license header to the test file
- This change ensures consistent licensing and copyright information across the project
@flc1125 flc1125 marked this pull request as ready for review September 13, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants