sdk/metric: add example for metricdatatest package#7323
sdk/metric: add example for metricdatatest package#7323pellared merged 18 commits intoopen-telemetry:mainfrom
Conversation
|
@sanojsubran Hi, thank you for your contribution. We need to verify it through the CLA before proceeding to review. https://github.com/open-telemetry/opentelemetry-go/blob/main/CONTRIBUTING.md#how-to-receive-comments |
|
@flc1125 Sure, I will do it as soon as possible. I am waiting for my employer's approval to sign the CLA. |
Signed-off-by: sanojsubran <sanoj.subran@ibm.com>
|
Hi @flc1125, |
|
I would split this example into several smaller and atomic ones. One for each type of metric for example. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7323 +/- ##
=====================================
Coverage 82.9% 82.9%
=====================================
Files 267 267
Lines 24982 24982
=====================================
Hits 20728 20728
Misses 3878 3878
Partials 376 376 🚀 New features to boost your workflow:
|
@dmathieu Sure, I'll add the changes. |
Signed-off-by: sanojsubran <sanoj.subran@ibm.com>
|
I have split the examples to separate ones, addressing the exported methods. Kindly review the changes. |
pellared
left a comment
There was a problem hiding this comment.
Same comments apply to other examples
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Signed-off-by: sanojsubran <sanoj.subran@ibm.com>
Co-authored-by: Flc゛ <four_leaf_clover@foxmail.com>
Co-authored-by: Flc゛ <four_leaf_clover@foxmail.com>
Signed-off-by: sanojsubran <sanoj.subran@ibm.com>
Signed-off-by: sanojsubran <sanoj.subran@ibm.com>
Signed-off-by: sanojsubran <sanoj.subran@ibm.com>
|
@sanojsubran, thank you very much for your contribution 🏅 |
This PR addresses the issue #7050 by adding an example for the
metricdatatestpackage.The example uses a manualreader to collect the metrics and verify the expected data against the actual data using the
metricdatatestpackage.Disclosure: I have used GenAI tools for understanding sections of code base and code changes in this PR, but in a limited way as per the policy guidelines mentioned in the community documentation.