Skip to content

Fix CPUModeSystem variable name#7233

Merged
pellared merged 6 commits intoopen-telemetry:mainfrom
MrAlias:fix-7232
Aug 25, 2025
Merged

Fix CPUModeSystem variable name#7233
pellared merged 6 commits intoopen-telemetry:mainfrom
MrAlias:fix-7232

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Aug 21, 2025

Do not trim a package prefix when it is the same as the package name. Assume the name itself has semantic meaning and will not stutter.

Fix #7232

Do not trim a package prefix when it is the same as the package name.
Assume the name itself has semantic meaning and will not stutter.
@MrAlias MrAlias added this to the v1.38.0 milestone Aug 21, 2025
@MrAlias MrAlias added Skip Changelog PRs that do not require a CHANGELOG.md entry pkg:semconv Related to a semconv package labels Aug 21, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.0%. Comparing base (be28c6b) to head (f6852d5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7233   +/-   ##
=====================================
  Coverage   83.0%   83.0%           
=====================================
  Files        265     265           
  Lines      24660   24660           
=====================================
+ Hits       20476   20477    +1     
+ Misses      3808    3807    -1     
  Partials     376     376           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pellared pellared merged commit e7fa5ba into open-telemetry:main Aug 25, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:semconv Related to a semconv package Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"system" CPU mode in systemconv is defined as CPUMode var

3 participants