Skip to content

refactor(logger): Flatten logger.initSelfObservability into logger.newLoggerr and use t.Cleanup instead of defer#7228

Merged
MrAlias merged 5 commits intoopen-telemetry:mainfrom
yumosx:yumosx-no-side-effect
Aug 24, 2025
Merged

refactor(logger): Flatten logger.initSelfObservability into logger.newLoggerr and use t.Cleanup instead of defer#7228
MrAlias merged 5 commits intoopen-telemetry:mainfrom
yumosx:yumosx-no-side-effect

Conversation

@yumosx
Copy link
Copy Markdown
Member

@yumosx yumosx commented Aug 21, 2025

  • Flatten logger.initSelfObservability into logger.newLoggerr
  • use t.Cleanup instead of defer

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.0%. Comparing base (c2a6172) to head (e96b38a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7228   +/-   ##
=====================================
  Coverage   83.0%   83.0%           
=====================================
  Files        265     265           
  Lines      24661   24660    -1     
=====================================
+ Hits       20473   20475    +2     
+ Misses      3811    3809    -2     
+ Partials     377     376    -1     
Files with missing lines Coverage Δ
sdk/log/logger.go 100.0% <100.0%> (+3.7%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 21, 2025
@MrAlias MrAlias merged commit 9818ea8 into open-telemetry:main Aug 24, 2025
38 checks passed
@MrAlias MrAlias added this to the v1.38.0 milestone Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants