Skip to content

sdk/trace: trace id high 64 bit tests#7212

Merged
dmathieu merged 10 commits intoopen-telemetry:mainfrom
mahendrabishnoi2:chore/trace-id-generator-test
Oct 6, 2025
Merged

sdk/trace: trace id high 64 bit tests#7212
dmathieu merged 10 commits intoopen-telemetry:mainfrom
mahendrabishnoi2:chore/trace-id-generator-test

Conversation

@mahendrabishnoi2
Copy link
Copy Markdown
Member

Fixes #7160

  • Modified testIDGenerator to have both low and high bits (in uint64 form) since we can't store 128 bits integer
  • start with high seed values (taken from sdk/trace: More trace id tests #7155)
  • validate both high and low 64 bits of trace id

Does not need a CHANGELOG entry - test only.

@mahendrabishnoi2 mahendrabishnoi2 marked this pull request as ready for review August 16, 2025 16:12
@mahendrabishnoi2
Copy link
Copy Markdown
Member Author

Reviewers, please add skip changelog label.

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 18, 2025
@mahendrabishnoi2
Copy link
Copy Markdown
Member Author

This PR is ready for review.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.7%. Comparing base (5937fc8) to head (0b3b276).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7212   +/-   ##
=====================================
  Coverage   85.7%   85.7%           
=====================================
  Files        284     284           
  Lines      25017   25017           
=====================================
+ Hits       21440   21442    +2     
+ Misses      3198    3196    -2     
  Partials     379     379           

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit comments regarding the names

Comment thread sdk/trace/trace_test.go Outdated
Comment thread sdk/trace/trace_test.go Outdated
dmathieu and others added 2 commits October 6, 2025 11:01
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@dmathieu dmathieu merged commit a10652b into open-telemetry:main Oct 6, 2025
30 checks passed
@MrAlias MrAlias added this to the v1.39.0 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test the high 64-bits of the trace ID for the ID generator

5 participants