Use t.Cleanup instead of defer in sdk/trace#7208
Merged
pellared merged 4 commits intoopen-telemetry:mainfrom Aug 18, 2025
Merged
Use t.Cleanup instead of defer in sdk/trace#7208pellared merged 4 commits intoopen-telemetry:mainfrom
t.Cleanup instead of defer in sdk/trace#7208pellared merged 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7208 +/- ##
=======================================
- Coverage 83.0% 82.9% -0.1%
=======================================
Files 265 265
Lines 24638 24638
=======================================
- Hits 20450 20449 -1
- Misses 3810 3811 +1
Partials 378 378 🚀 New features to boost your workflow:
|
dashpole
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the testing system ensure proper cleanup ordering and execution. Do not wait to function return to run all the
defers from the loops.