Pool attribute slices in stdouttrace self-observability#7201
Merged
MrAlias merged 5 commits intoopen-telemetry:mainfrom Aug 18, 2025
Merged
Pool attribute slices in stdouttrace self-observability#7201MrAlias merged 5 commits intoopen-telemetry:mainfrom
stdouttrace self-observability#7201MrAlias merged 5 commits intoopen-telemetry:mainfrom
Conversation
2bd7f83 to
b6f4eb6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7201 +/- ##
=====================================
Coverage 83.0% 83.0%
=====================================
Files 265 265
Lines 24651 24661 +10
=====================================
+ Hits 20464 20476 +12
+ Misses 3810 3808 -2
Partials 377 377
🚀 New features to boost your workflow:
|
b6f4eb6 to
b6c4710
Compare
dashpole
approved these changes
Aug 17, 2025
pellared
approved these changes
Aug 18, 2025
The pool is only used on the error path now. Include that in the benchmark to provide evidence of performance improvement.
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Aug 18, 2025
…etry#7201) ### Benchmarks ```terminal goos: linux goarch: amd64 pkg: go.opentelemetry.io/otel/exporters/stdout/stdouttrace cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz │ main.txt │ stdouttrace-pool-obs-attrs.txt │ │ sec/op │ sec/op vs base │ ExporterExportSpans-8 30.55µ ± 2% 31.76µ ± 3% +3.96% (p=0.000 n=10) │ main.txt │ stdouttrace-pool-obs-attrs.txt │ │ B/op │ B/op vs base │ ExporterExportSpans-8 6.538Ki ± 0% 6.353Ki ± 0% -2.84% (p=0.000 n=10) │ main.txt │ stdouttrace-pool-obs-attrs.txt │ │ allocs/op │ allocs/op vs base │ ExporterExportSpans-8 135.0 ± 0% 134.0 ± 0% -0.74% (p=0.000 n=10) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarks