Skip to content

chore: enable ptrToRefParam from go-critic#7131

Merged
MrAlias merged 2 commits intoopen-telemetry:mainfrom
mmorel-35:gocritic/ptrToRefParam
Aug 7, 2025
Merged

chore: enable ptrToRefParam from go-critic#7131
MrAlias merged 2 commits intoopen-telemetry:mainfrom
mmorel-35:gocritic/ptrToRefParam

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Aug 4, 2025 •
edited
Loading

Description

Enable and fixes ptrToRefParam rule from go-critic

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.9%. Comparing base (4b8da88) to head (0296723).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7131     +/-   ##
=======================================
- Coverage   82.9%   82.9%   -0.1%     
=======================================
  Files        263     263             
  Lines      24503   24503             
=======================================
- Hits       20333   20331      -2     
- Misses      3793    3795      +2     
  Partials     377     377
Files with missing lines Coverage Δ
...metric/internal/aggregate/exponential_histogram.go 96.6% <100.0%> (ø)
sdk/metric/internal/aggregate/histogram.go 100.0% <100.0%> (ø)
sdk/metric/internal/aggregate/lastvalue.go 100.0% <100.0%> (ø)
sdk/metric/internal/aggregate/sum.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmorel-35 mmorel-35 force-pushed the gocritic/ptrToRefParam branch 2 times, most recently from 32761e8 to fa2ef9e Compare August 4, 2025 20:41
@mmorel-35
chore: enable ptrToRefParam from go-critic
206bd10 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the gocritic/ptrToRefParam branch from fa2ef9e to 206bd10 Compare August 4, 2025 20:51
@mmorel-35 mmorel-35 marked this pull request as ready for review August 4, 2025 20:52
@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 4, 2025
@MrAlias MrAlias merged commit 6d3e127 into open-telemetry:main Aug 7, 2025
31 checks passed
@mmorel-35 mmorel-35 deleted the gocritic/ptrToRefParam branch August 7, 2025 18:56
@MrAlias MrAlias added this to the v1.38.0 milestone Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrAlias MrAlias MrAlias approved these changes

@flc1125 flc1125 flc1125 approved these changes

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

v1.38.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mmorel-35 @MrAlias @flc1125