Skip to content

chore: enable gocritic linter#7095

Merged
MrAlias merged 17 commits intoopen-telemetry:mainfrom
mmorel-35:go-critic/enable-all
Jul 29, 2025
Merged

chore: enable gocritic linter#7095
MrAlias merged 17 commits intoopen-telemetry:mainfrom
mmorel-35:go-critic/enable-all

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Jul 28, 2025 •
edited
Loading

Description

Enable and fixes several rules from gocritic linter

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.60440% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.9%. Comparing base (8955578) to head (56aa131).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
attribute/encoder.go 66.6% 1 Missing ⚠️
exporters/otlp/otlplog/otlploghttp/client.go 50.0% 0 Missing and 1 partial ⚠️
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 50.0% 0 Missing and 1 partial ⚠️
trace/tracestate.go 66.6% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7095   +/-   ##
=====================================
  Coverage   82.9%   82.9%           
=====================================
  Files        262     262           
  Lines      24449   24460   +11     
=====================================
+ Hits       20278   20288   +10     
- Misses      3795    3796    +1     
  Partials     376     376
Files with missing lines Coverage Δ
attribute/filter.go 100.0% <100.0%> (ø)
baggage/baggage.go 99.3% <100.0%> (ø)
exporters/otlp/otlplog/otlploggrpc/client.go 91.9% <100.0%> (ø)
exporters/otlp/otlplog/otlploggrpc/config.go 90.2% <100.0%> (ø)
exporters/otlp/otlptrace/otlptracehttp/client.go 74.5% <100.0%> (ø)
exporters/prometheus/exporter.go 85.7% <100.0%> (ø)
exporters/zipkin/model.go 99.4% <100.0%> (ø)
exporters/zipkin/zipkin.go 80.3% <100.0%> (ø)
sdk/internal/x/x.go 100.0% <100.0%> (ø)
sdk/metric/exemplar/fixed_size_reservoir.go 97.6% <100.0%> (-0.1%) ⬇️
... and 13 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mmorel-35 mmorel-35 force-pushed the go-critic/enable-all branch 20 times, most recently from 41ed127 to 68582d4 Compare July 28, 2025 18:15
mmorel-35 added 9 commits July 28, 2025 21:38
@mmorel-35
chore: enable go-critic linter
d442107 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable unslice rule from go-critic
edfb6e3 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable appendCombine rule from go-critic
adc09ec 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable httpNoBody rule from go-critic
d96479e 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable preferWriteByte rule from go-critic
2f5dc04 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable sloppyLen rule from go-critic
26605db 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable emptyStringTest rule from go-critic
a962e41 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable preferStringWriter rule from go-critic
ebcf492 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable equalFold rule from go-critic
ac427c3 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35 added 2 commits July 28, 2025 21:38
@mmorel-35
chore: enable stringConcatSimplify rule from go-critic
b14d3f5 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable elseif rule from go-critic
c85a7cb 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the go-critic/enable-all branch 5 times, most recently from e9d29d6 to b15e2ac Compare July 28, 2025 20:00
@mmorel-35
chore: enable typeUnparen rule from go-critic
785a432 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the go-critic/enable-all branch 2 times, most recently from 4a02758 to 1bd40fb Compare July 28, 2025 20:24
mmorel-35 added 2 commits July 28, 2025 22:35
@mmorel-35
chore: enable captLocal rule from go-critic
2806ca2 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: enable assignOp rule from go-critic
27860e3 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the go-critic/enable-all branch from 1bd40fb to 27860e3 Compare July 28, 2025 20:35
@mmorel-35 mmorel-35 marked this pull request as ready for review July 28, 2025 20:40
@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 29, 2025
MrAlias
MrAlias reviewed Jul 29, 2025
View reviewed changes
Comment thread semconv/internal/v2/http.go Outdated
Comment thread semconv/internal/v2/http.go Outdated
Comment thread semconv/internal/v3/http.go Outdated
Comment thread semconv/internal/v3/http.go Outdated
Comment thread semconv/internal/v4/http.go Outdated
Comment thread semconv/internal/v4/http.go Outdated
@mmorel-35 @MrAlias
Apply suggestions from code review
1f78f97 
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit 9823913 into open-telemetry:main Jul 29, 2025
29 of 30 checks passed
@mmorel-35 mmorel-35 deleted the go-critic/enable-all branch July 29, 2025 16:25
@MrAlias MrAlias added this to the v1.38.0 milestone Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias MrAlias approved these changes

@flc1125 flc1125 flc1125 approved these changes

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

v1.38.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mmorel-35 @dmathieu @MrAlias @flc1125