log: Add String method to Value and KeyValue#5117
Merged
pellared merged 5 commits intoopen-telemetry:mainfrom Apr 2, 2024
Merged
log: Add String method to Value and KeyValue#5117pellared merged 5 commits intoopen-telemetry:mainfrom
pellared merged 5 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5117 +/- ##
=======================================
- Coverage 83.8% 83.8% -0.1%
=======================================
Files 248 248
Lines 16253 16275 +22
=======================================
+ Hits 13625 13643 +18
- Misses 2340 2344 +4
Partials 288 288
|
MrAlias
reviewed
Mar 29, 2024
MrAlias
reviewed
Mar 29, 2024
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
XSAM
approved these changes
Mar 31, 2024
dmathieu
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4952
Implementation based on: https://pkg.go.dev/log/slog#Value.String and https://pkg.go.dev/log/slog#Attr.String.
Comment that it is for debugging purpose only inspired by https://pkg.go.dev/time#Time.String