Use uint64 Count consistently in metric aggregation#1430
Merged
jmacd merged 3 commits intoopen-telemetry:masterfrom Jan 6, 2021
Merged
Use uint64 Count consistently in metric aggregation#1430jmacd merged 3 commits intoopen-telemetry:masterfrom
jmacd merged 3 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1430 +/- ##
========================================
- Coverage 78.6% 78.6% -0.1%
========================================
Files 126 126
Lines 6369 6367 -2
========================================
- Hits 5011 5009 -2
Misses 1114 1114
Partials 244 244
|
Aneurysm9
approved these changes
Jan 3, 2021
XSAM
approved these changes
Jan 3, 2021
Contributor
Author
|
@bogdandrutu Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OTLP Export code path uses a
uint64for histogram bucket counts. This meant an extra copy because this code, which predates the OTLP definition, chose int64 and float64 inconsistently. This PR avoids the extra copy and uses uint64 for counts consistently across aggregators and histogram buckets.The change from int64 to uint64 is not lossy because counts should never be negative.
The change from float64 to uint64 matters only in theory for a discussion about sampling in a statsd receiver.
[In the statsd receiver case, I'm prepared to argue for the use of integer-reciprocal sampling rates to mitigate this issue.]