Skip to content

Conversation

@axw
Copy link
Contributor

@axw axw commented Oct 29, 2025

Description

Update OCB to set CGO_ENABLED=0 by default, and make it configurable with a new dist::cgo_enabled setting.

Link to tracking issue

Fixes #10028

Testing

Test added

Documentation

Updated

... and make it configurable with a new dist::cgo_enabled setting.
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (ab33d4b) to head (3a482a2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14094      +/-   ##
==========================================
- Coverage   92.27%   92.25%   -0.03%     
==========================================
  Files         657      657              
  Lines       41100    41107       +7     
==========================================
- Hits        37926    37924       -2     
- Misses       2173     2179       +6     
- Partials     1001     1004       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@axw axw marked this pull request as ready for review October 29, 2025 03:40
@axw axw requested a review from a team as a code owner October 29, 2025 03:40
@axw axw requested a review from dmathieu October 29, 2025 03:40
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @axw

@codeboten codeboten enabled auto-merge October 29, 2025 20:39
@codeboten codeboten added this pull request to the merge queue Oct 29, 2025
Merged via the queue into open-telemetry:main with commit 1847c2e Oct 29, 2025
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 29, 2025
@axw axw deleted the builder-default-cgo-disabled branch October 29, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cmd/builder] Disable CGO by default

4 participants