Include annotations in rule AST#6771
Merged
johanfylling merged 2 commits intoopen-policy-agent:mainfrom May 30, 2024
Merged
Conversation
Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Member
Author
Contributor
johanfylling
left a comment
There was a problem hiding this comment.
Looks good 👍, but I think there's one issue we need to fix.
| var j int | ||
| var found bool | ||
| for i, a := range cpy { | ||
| if rule.Loc().Row > a.Location.Row { |
Contributor
There was a problem hiding this comment.
Since we're only looking at rules declared below the annotation, won't we be dropping document-scope annotations for rules that don't happen to be located below the annotation, but have an applicable path?
E.g. this policy might not be good form, but the annotation block applies to both rules data.example.p:
package example
import rego.v1
p contains {1, rego.metadata.chain()}
# METADATA
# scope: document
# title: p-rules
p contains {2, rego.metadata.chain()}
…ing on row after rule Signed-off-by: Johan Fylling <johan.dev@fylling.se>
anderseknert
approved these changes
May 30, 2024
johanfylling
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.