fix: fall back to TCP if on a read-only disk (#1072)

Skarlso · web-flow · commit a7be1bf5ce0d · 2025-10-24T10:05:21.000Z
&lt;!-- markdownlint-disable MD041 --&gt;
#### What this PR does / why we need it

In a read-only disk ( like a scratch container ) the flow to detect
connection fails because it can't create a folder. In that case it
should fall back to TCP.

#### Which issue(s) this PR fixes
&lt;!--
Usage: `Fixes #&lt;issue number&gt;`, or `Fixes (paste link of issue)`.
--&gt;

---------

Signed-off-by: Gergely Brautigam &lt;182850+Skarlso@users.noreply.github.com&gt;
diff --git a/bindings/go/plugin/manager/manager.go b/bindings/go/plugin/manager/manager.go
@@ -234,7 +234,7 @@ func (pm *PluginManager) addPlugin(ctx context.Context, ocmConfig *genericv1.Con
 	// Create a command that can then be managed.
 	pluginCmd := exec.CommandContext(ctx, cleanPath(plugin.Path), "--config", string(serialized)) //nolint:gosec // G204 does not apply
 	pluginCmd.Cancel = func() error {
-		slog.Info("killing plugin process because the parent context is cancelled", "id", plugin.ID)
+		slog.InfoContext(ctx, "killing plugin process because the parent context is cancelled", "id", plugin.ID)
 		return pluginCmd.Process.Kill()
 	}
 
@@ -305,10 +305,13 @@ func (pm *PluginManager) addPlugin(ctx context.Context, ocmConfig *genericv1.Con
 }
 
 func determineConnectionType(ctx context.Context) (mtypes.ConnectionType, error) {
+	// if we can't create a temp folder ( for example we are in a scratch container ) we default to TCP
 	tmp, err := os.MkdirTemp("", "")
 	if err != nil {
-		return "", fmt.Errorf("failed to create temporary directory: %w", err)
+		slog.DebugContext(ctx, "failed to create temporary folder, falling back to TCP connection", "err", err.Error())
+		return mtypes.TCP, nil
 	}
+
 	defer func() {
 		_ = os.RemoveAll(tmp)
 	}()
