Export named concurrently + fix TS errors with Node16#456
Merged
gustavohenke merged 8 commits intomainfrom Feb 4, 2024
Merged
Conversation
Makes it possible for IDEs to infer types from the declarations before building.
This reverts commit babbc73. These types aren't shipped in the bundle.
Member
Author
|
Bit of a bump @paescuj, might proceed without a review in a few days |
50 tasks
Member
Author
|
Hey! This is now fixed in v9.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bunch of issues when using concurrently
require()function (from both TS and pure JS)On the side, the named export
concurrentlyis now the fully configured concurrently.This was done to simplify the exports in the index files (most likely specific to ESM, but I've lost track of why exactly).
Will add some smoke tests in a follow up PR so that this one stays mostly focused to the core changes.
Fixes #399
Fixes #454
Closes #440