Skip to content

Support hex prefix colors with modifiers#450

Merged
gustavohenke merged 6 commits into
open-cli-tools:mainfrom
garretmh:hex-prefix-color-with-modifiers
Aug 30, 2025
Merged

Support hex prefix colors with modifiers#450
gustavohenke merged 6 commits into
open-cli-tools:mainfrom
garretmh:hex-prefix-color-with-modifiers

Conversation

@garretmh

@garretmh garretmh commented Nov 3, 2023

Copy link
Copy Markdown
Contributor

Extends #260

gustavohenke
gustavohenke previously requested changes Dec 7, 2023
View reviewed changes

@gustavohenke gustavohenke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with this PR, do you mind taking a look at them?

@coveralls

coveralls commented Dec 13, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 99.202% (+0.005%) from 99.197%
when pulling fe15928 on garretmh:hex-prefix-color-with-modifiers
into 0c64306 on open-cli-tools:main.

@garretmh

garretmh commented Dec 13, 2023

Copy link
Copy Markdown
Contributor Author

Apologies, I addressed the check failures.

@garretmh garretmh requested a review from gustavohenke January 22, 2024 05:08
@markholland

markholland commented Feb 27, 2025

Copy link
Copy Markdown

Would love to see this one come in, wanting to apply bold to a hex.

@paescuj paescuj force-pushed the hex-prefix-color-with-modifiers branch from d6e6fe7 to d3cf095 Compare August 25, 2025 18:26
@coveralls

coveralls commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same
when pulling 9ad6ea1 on garretmh:hex-prefix-color-with-modifiers
into 414cd01 on open-cli-tools:main.

paescuj
paescuj approved these changes Aug 25, 2025
View reviewed changes

@paescuj paescuj left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned it with the latest state of the codebase 👍
LGTM, thanks @garretmh!

@paescuj paescuj requested review from gustavohenke and removed request for gustavohenke August 25, 2025 18:29
gustavohenke
gustavohenke approved these changes Aug 30, 2025
View reviewed changes

@gustavohenke gustavohenke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gustavohenke gustavohenke merged commit 8b15b92 into open-cli-tools:main Aug 30, 2025
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gustavohenke gustavohenke gustavohenke approved these changes

@paescuj paescuj paescuj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@garretmh @coveralls @markholland @gustavohenke @paescuj