ginkgo: fix data race

pohly · onsi · commit ece19c896cf2 · 2025-12-08T07:37:51.000-07:00
Write at 0x00c000368528 by goroutine 25:
      os/exec.(*Cmd).Wait()
          os/exec/exec.go:926 +0x1a4
      github.com/onsi/ginkgo/v2/ginkgo/internal.runParallel.func2()
          github.com/onsi/ginkgo/v2@v2.27.2/ginkgo/internal/run.go:231 +0x37

    Previous read at 0x00c000368528 by goroutine 96714:
      github.com/onsi/ginkgo/v2/ginkgo/internal.runParallel.func1()
          github.com/onsi/ginkgo/v2@v2.27.2/ginkgo/internal/run.go:228 +0x3b
      github.com/onsi/ginkgo/v2/internal/parallel_support.(*ServerHandler).procIsAlive()
          github.com/onsi/ginkgo/v2@v2.27.2/internal/parallel_support/server_handler.go:133 +0x121

The problem is that cmd.ProcessState is not thread-safe. The solution is an
atomic bool which gets checked instead and which is written once when the
goroutine waiting for the command has determined that the command has exited.
diff --git a/ginkgo/internal/run.go b/ginkgo/internal/run.go
@@ -9,6 +9,7 @@ import (
 	"path/filepath"
 	"regexp"
 	"strings"
+	"sync/atomic"
 	"syscall"
 	"time"
 
@@ -224,8 +225,9 @@ func runParallel(suite TestSuite, ginkgoConfig types.SuiteConfig, reporterConfig
 		args = append(args, additionalArgs...)
 
 		cmd, buf := buildAndStartCommand(suite, args, false)
+		var exited atomic.Bool
 		procOutput[proc-1] = buf
-		server.RegisterAlive(proc, func() bool { return cmd.ProcessState == nil || !cmd.ProcessState.Exited() })
+		server.RegisterAlive(proc, func() bool { return !exited.Load() })
 
 		go func() {
 			cmd.Wait()
@@ -234,6 +236,7 @@ func runParallel(suite TestSuite, ginkgoConfig types.SuiteConfig, reporterConfig
 				passed:               (exitStatus == 0) || (exitStatus == types.GINKGO_FOCUS_EXIT_CODE),
 				hasProgrammaticFocus: exitStatus == types.GINKGO_FOCUS_EXIT_CODE,
 			}
+			exited.Store(true)
 		}()
 	}
 
