Skip to content

Throw TypeError#7366

Merged
justinchuby merged 1 commit intoonnx:mainfrom
cyyever:typeerror
Oct 2, 2025
Merged

Throw TypeError#7366
justinchuby merged 1 commit intoonnx:mainfrom
cyyever:typeerror

Conversation

@cyyever
Copy link
Copy Markdown
Contributor

@cyyever cyyever commented Oct 2, 2025

Description

Use TypeError for type exceptions.

Motivation and Context

More pythonic code.

@cyyever cyyever requested review from a team as code owners October 2, 2025 05:32
@github-project-automation github-project-automation Bot moved this to In progress in PR Tracker Oct 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.42%. Comparing base (5290dcd) to head (339dcd7).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnx/reference/ops/op_unsqueeze.py 0.00% 1 Missing ⚠️
onnx/tools/update_model_dims.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7366   +/-   ##
=======================================
  Coverage   54.42%   54.42%           
=======================================
  Files         511      511           
  Lines       31885    31885           
  Branches     2873     2873           
=======================================
  Hits        17355    17355           
  Misses      13741    13741           
  Partials      789      789

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security AI found potential problems Oct 2, 2025
View reviewed changes
Comment thread onnx/reference/ops/op_reduce_sum.py Fixed
@github-project-automation github-project-automation Bot moved this from In progress to Reviewer approved in PR Tracker Oct 2, 2025
@cyyever
Throw TypeError
339dcd7 
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
@justinchuby justinchuby merged commit 3721830 into onnx:main Oct 2, 2025
49 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in PR Tracker Oct 2, 2025
@cyyever cyyever deleted the typeerror branch October 2, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees

No one assigned

Labels

module: reference implementation

Projects

PR Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyyever @justinchuby @github-advanced-security