Override __repr__ for some proto classes (#7259)#7314
Merged
justinchuby merged 2 commits intorel-1.19.1from Sep 23, 2025
Merged
Override __repr__ for some proto classes (#7259)#7314justinchuby merged 2 commits intorel-1.19.1from
justinchuby merged 2 commits intorel-1.19.1from
Conversation
Override __repr__ for some proto classes to make it more efficient because. Prior to this change, calling repr on a big model proto would cause a costly serialization to run which dumps a lot of text. This change makes `repr(model_proto)` to return `'<onnx.onnx_ml_pb2.ModelProto object at 0x7572f254ada0>'`. Users can still call `str()` model proto classes to obtain a prototext representation. This also does not affect `print()` because print calls `str()`. Fix #4738 --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel-1.19.1 #7314 +/- ##
=============================================
Coverage ? 53.76%
=============================================
Files ? 512
Lines ? 32217
Branches ? 2948
=============================================
Hits ? 17321
Misses ? 14123
Partials ? 773 ☔ View full report in Codecov by Sentry. |
gramalingam
reviewed
Sep 22, 2025
titaiwangms
approved these changes
Sep 22, 2025
Member
Author
|
I am going to merge this PR, and if desired create a follow up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Override repr for some proto classes to make it more efficient
because. Prior to this change, calling repr on a big model proto would
cause a costly serialization to run which dumps a lot of text. This
change makes
repr(model_proto)to return'<onnx.onnx_ml_pb2.ModelProto object at 0x7572f254ada0>'.Users can still call
str()model proto classes to obtain a prototextrepresentation.
This also does not affect
print()because print callsstr().Fix #4738
Signed-off-by: Justin Chu justinchuby@users.noreply.github.com