Update rotary_embedding reference implementation and tests (#7304, #7316)#7313
Merged
justinchuby merged 3 commits intorel-1.19.1from Sep 22, 2025
Merged
Update rotary_embedding reference implementation and tests (#7304, #7316)#7313justinchuby merged 3 commits intorel-1.19.1from
justinchuby merged 3 commits intorel-1.19.1from
Conversation
### Description <!-- - Describe your changes. --> Add assertion in reference op of rotary embedding to follow ONNX spec. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> In ONNX spec, `cos_cache` and `sin_cache` are explicitly stated to have either rotary_embedding_dim/2 or head_size/2 in the final dim. However, reference op did not force it. --------- Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel-1.19.1 #7313 +/- ##
=============================================
Coverage ? 53.75%
=============================================
Files ? 512
Lines ? 32214
Branches ? 2948
=============================================
Hits ? 17318
Misses ? 14123
Partials ? 773 ☔ View full report in Codecov by Sentry. |
titaiwangms
approved these changes
Sep 22, 2025
gramalingam
reviewed
Sep 22, 2025
gramalingam
approved these changes
Sep 22, 2025
titaiwangms
added a commit
that referenced
this pull request
Sep 22, 2025
Address comments #7313 (comment) --------- Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Address comments #7313 (comment) --------- Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherrypick of