Skip to content

Clean up shape inference imports#7278

Merged
justinchuby merged 1 commit intomainfrom
justinchu/shape-import
Sep 5, 2025
Merged

Clean up shape inference imports#7278
justinchuby merged 1 commit intomainfrom
justinchu/shape-import

Conversation

@justinchuby
Copy link
Copy Markdown
Member

@justinchuby justinchuby commented Sep 5, 2025

Import IR_VERSION separately (not from onnx) to avoid potential circular import situations.

@justinchuby
Clean up shape inference imports
7e45239 
Import IR_VERSION separately (not from onnx) to avoid potential circular import situations.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby requested a review from a team as a code owner September 5, 2025 01:13
@github-project-automation github-project-automation Bot moved this to In progress in PR Tracker Sep 5, 2025
@justinchuby justinchuby requested a review from andife September 5, 2025 01:13
@justinchuby justinchuby enabled auto-merge (squash) September 5, 2025 01:13
@justinchuby justinchuby added the topic: better engineering Improve engineering quality of the project label Sep 5, 2025
@justinchuby justinchuby mentioned this pull request Sep 5, 2025
Merged
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.34%. Comparing base (062ee92) to head (7e45239).
⚠️ Report is 104 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7278   +/-   ##
=======================================
  Coverage   54.34%   54.34%           
=======================================
  Files         511      511           
  Lines       31821    31821           
  Branches     2848     2848           
=======================================
  Hits        17292    17292           
  Misses      13753    13753           
  Partials      776      776

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-project-automation github-project-automation Bot moved this from In progress to Reviewer approved in PR Tracker Sep 5, 2025
@justinchuby justinchuby force-pushed the justinchu/shape-import branch 2 times, most recently from 0b2373c to 7e45239 Compare September 5, 2025 01:33
@justinchuby justinchuby merged commit ca69d6e into main Sep 5, 2025
63 of 79 checks passed
@justinchuby justinchuby deleted the justinchu/shape-import branch September 5, 2025 02:05
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in PR Tracker Sep 5, 2025
@titaiwangms titaiwangms added the module: shape inference Issues related to shape inference label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andife andife andife approved these changes

@titaiwangms titaiwangms Awaiting requested review from titaiwangms

Assignees

No one assigned

Labels

module: shape inference Issues related to shape inference topic: better engineering Improve engineering quality of the project

Projects

PR Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinchuby @andife @titaiwangms