Reference evaluator: treat empty axes as empty#7244
Merged
justinchuby merged 2 commits intoonnx:mainfrom Aug 25, 2025
Merged
Conversation
Signed-off-by: ryota717 <ryota.nishijima@fout.jp>
Signed-off-by: ryota717 <ryota.nishijima@fout.jp>
25636c7 to
74ade32
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7244 +/- ##
=======================================
Coverage 54.33% 54.33%
=======================================
Files 511 511
Lines 31819 31819
Branches 2848 2848
=======================================
Hits 17290 17290
Misses 13753 13753
Partials 776 776 ☔ View full report in Codecov by Sentry. |
cbourjau
requested changes
Aug 24, 2025
Contributor
cbourjau
left a comment
There was a problem hiding this comment.
Thanks! Could you add a unit test? I think adding an "example" to the respective files under onnx/backend/test/case/node should do the trick.
This comment was marked as resolved.
This comment was marked as resolved.
justinchuby
approved these changes
Aug 25, 2025
Member
justinchuby
left a comment
There was a problem hiding this comment.
I think we can merge this first, thanks! Feel free to consider contributing a test case as suggested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the
is_axes_emptymethod to treat empty axis empty.And as refactor, use this method in
ReduceSum_13.Motivation and Context
#7140