Fix Range input rank in Attention op function definition#7240
Merged
yuanyao-nv merged 3 commits intoonnx:mainfrom Aug 19, 2025
Merged
Fix Range input rank in Attention op function definition#7240yuanyao-nv merged 3 commits intoonnx:mainfrom
yuanyao-nv merged 3 commits intoonnx:mainfrom
Conversation
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
justinchuby
reviewed
Aug 19, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7240 +/- ##
=======================================
Coverage 54.33% 54.33%
=======================================
Files 511 511
Lines 31819 31819
Branches 2848 2848
=======================================
Hits 17290 17290
Misses 13753 13753
Partials 776 776 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
titaiwangms
approved these changes
Aug 19, 2025
justinchuby
reviewed
Aug 19, 2025
justinchuby
approved these changes
Aug 19, 2025
Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
justinchuby
approved these changes
Aug 19, 2025
yuanyao-nv
added a commit
to yuanyao-nv/onnx
that referenced
this pull request
Aug 19, 2025
### Description In the Attentiion op definition, update the inputs to Range to be scalars as opposed to 1-element vectors, as required by the Range op spec. ### Motivation and Context See discussion [here](onnx#7164 (comment)). --------- Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
xadupre
pushed a commit
to xadupre/onnx
that referenced
this pull request
Aug 31, 2025
### Description In the Attentiion op definition, update the inputs to Range to be scalars as opposed to 1-element vectors, as required by the Range op spec. ### Motivation and Context See discussion [here](onnx#7164 (comment)). --------- Signed-off-by: Yuan Yao <yuanyao@nvidia.com> Signed-off-by: xadupre <xadupre@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the Attentiion op definition, update the inputs to Range to be scalars as opposed to 1-element vectors, as required by the Range op spec.
Motivation and Context
See discussion here.