fixed handling of empty inputs for the softmax operator#7206
Merged
justinchuby merged 1 commit intoonnx:mainfrom Aug 6, 2025
Merged
fixed handling of empty inputs for the softmax operator#7206justinchuby merged 1 commit intoonnx:mainfrom
justinchuby merged 1 commit intoonnx:mainfrom
Conversation
Signed-off-by: Konstantin Pueckler <konstantin.pueckler@quantco.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7206 +/- ##
==========================================
- Coverage 53.76% 53.75% -0.01%
==========================================
Files 512 512
Lines 32199 32201 +2
Branches 2944 2945 +1
==========================================
Hits 17311 17311
- Misses 14119 14120 +1
- Partials 769 770 +1 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Aug 6, 2025
MagellaX
pushed a commit
to MagellaX/onnx
that referenced
this pull request
Aug 9, 2025
### Description When given an empty input, ``softmax`` should return an output of the same shape. Currently, an exception is raised by ``X.max`` in that case. ### Motivation and Context We came across this problem when testing the onnxruntime via [onnx-tests](https://github.com/cbourjau/onnx-tests). Signed-off-by: Konstantin Pueckler <konstantin.pueckler@quantco.com> Signed-off-by: Yash solanki <alphacr792@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When given an empty input,
softmaxshould return an output of the same shape. Currently, an exception is raised byX.maxin that case.Motivation and Context
We came across this problem when testing the onnxruntime via onnx-tests.