Fix return type of HardSigmoid in reference implementation#7168
Merged
justinchuby merged 1 commit intoonnx:mainfrom Jul 24, 2025
Merged
Fix return type of HardSigmoid in reference implementation#7168justinchuby merged 1 commit intoonnx:mainfrom
justinchuby merged 1 commit intoonnx:mainfrom
Conversation
Signed-off-by: Konstantin Pueckler <konstantin.pueckler@quantco.com>
ac1b094 to
4a12f3e
Compare
justinchuby
approved these changes
Jul 24, 2025
alx256
pushed a commit
to alx256/onnx
that referenced
this pull request
Aug 1, 2025
### Description added cast of result to ``x.dtype`` which is necessary since the result needs to be of the same type as ``x`` regardless of the types of``alpha`` and ``beta``. ### Motivation and Context The problem arouse when testing onnx-reference via the https://github.com/cbourjau/onnx-tests tool. Signed-off-by: Konstantin Pueckler <konstantin.pueckler@quantco.com> Signed-off-by: Alexander Poulson <alexanderipoulson@gmail.com>
MagellaX
pushed a commit
to MagellaX/onnx
that referenced
this pull request
Aug 9, 2025
### Description added cast of result to ``x.dtype`` which is necessary since the result needs to be of the same type as ``x`` regardless of the types of``alpha`` and ``beta``. ### Motivation and Context The problem arouse when testing onnx-reference via the https://github.com/cbourjau/onnx-tests tool. Signed-off-by: Konstantin Pueckler <konstantin.pueckler@quantco.com> Signed-off-by: Yash solanki <alphacr792@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
added cast of result to
x.dtypewhich is necessary since the result needs to be of the same type asxregardless of the types ofalphaandbeta.Motivation and Context
The problem arouse when testing onnx-reference via the https://github.com/cbourjau/onnx-tests tool.