Update float8 table for the Cast op spec#7085
Merged
justinchuby merged 5 commits intomainfrom Jul 1, 2025
Merged
Conversation
Currect the float8 saturation behavior for Cast using table from the float8 technical documentation. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
commented
Jun 26, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7085 +/- ##
=======================================
Coverage 56.40% 56.40%
=======================================
Files 510 510
Lines 32721 32721
Branches 3093 3093
=======================================
Hits 18457 18457
Misses 13410 13410
Partials 854 854 ☔ View full report in Codecov by Sentry. |
xadupre
approved these changes
Jul 1, 2025
Member
Author
|
I don't understand what is blocking this merge. It's not clear from github |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currect the float8 saturation behavior for Cast using table from the float8 technical documentation https://onnx.ai/onnx/technical/float8.html, since the behavior for +- Inf and NaN was not correctly specified.
Fixes #6220