Clarify the axes input of [un]Squeeze to be 1D tensors#6888
Merged
justinchuby merged 2 commits intomainfrom May 5, 2025
Merged
Clarify the axes input of [un]Squeeze to be 1D tensors#6888justinchuby merged 2 commits intomainfrom
axes input of [un]Squeeze to be 1D tensors#6888justinchuby merged 2 commits intomainfrom
Conversation
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6888 +/- ##
=======================================
Coverage 56.31% 56.31%
=======================================
Files 509 509
Lines 32606 32606
Branches 3099 3099
=======================================
Hits 18363 18363
Misses 13385 13385
Partials 858 858 ☔ View full report in Codecov by Sentry. |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cyyever
approved these changes
Apr 16, 2025
gramalingam
approved these changes
May 5, 2025
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
May 19, 2025
### Description Clarify the `axes` input of [un]Squeeze to be 1D tensors. ### Motivation and Context Reduce ambiguity of the op spec. Fixes onnx#6886 --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com> Signed-off-by: gramalingam <grama@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify the
axesinput of [un]Squeeze to be 1D tensors.Motivation and Context
Reduce ambiguity of the op spec.
Fixes #6886