Deprecate printable_graph in helper#6803
Merged
justinchuby merged 1 commit intomainfrom Mar 28, 2025
Merged
Conversation
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6803 +/- ##
=======================================
Coverage 56.28% 56.28%
=======================================
Files 509 509
Lines 32579 32580 +1
Branches 3099 3099
=======================================
+ Hits 18336 18337 +1
Misses 13385 13385
Partials 858 858 ☔ View full report in Codecov by Sentry. |
cyyever
approved these changes
Mar 28, 2025
andife
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate printable_graph because it is not catching up with the latest of onnx. Recommend users to use
onnx.printer.to_textinstead.This PR also makes
create_op_set_id_version_mapprivate because it is intended as a private function.