Liqun/optional input#4326
Merged
liqunfu merged 6 commits intoonnx:function-experimentfrom Jul 21, 2022
liqunfu:liqun/optional_input
Merged
Liqun/optional input#4326liqunfu merged 6 commits intoonnx:function-experimentfrom liqunfu:liqun/optional_input
liqunfu merged 6 commits intoonnx:function-experimentfrom
liqunfu:liqun/optional_input
Conversation
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
gramalingam
reviewed
Jun 30, 2022
| ''' | ||
| ''' | ||
| if isinstance(proto, bytes): | ||
| proto = _deserialize(proto, LibProto()) |
Contributor
There was a problem hiding this comment.
Why deserialize and serialize back?
Contributor
Author
There was a problem hiding this comment.
Good point. TODO add so that I can make the codel change when working with LibProto - I need to merge this branch in order to build ort with my optional input branch.
gramalingam
reviewed
Jun 30, 2022
|
|
||
| optional string domain = 4; | ||
|
|
||
| optional int64 model_version = 5; |
Contributor
There was a problem hiding this comment.
Should this be lib_version ?
Contributor
There was a problem hiding this comment.
Adding comments just like in ModelProto would be helpful.
gramalingam
reviewed
Jun 30, 2022
| "optional(tensor(float))", "optional(tensor(double))", "optional(tensor(string))", | ||
| "optional(tensor(bool))", "optional(tensor(complex64))", "optional(tensor(complex128))"}; | ||
| "optional(tensor(bool))", "optional(tensor(complex64))", "optional(tensor(complex128))", | ||
| "tensor(float)"}; |
Contributor
There was a problem hiding this comment.
Don't understand this. Is it here by mistake?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context