Conversation
Signed-off-by: xadupre <xadupre@microsoft.com>
gramalingam
approved these changes
Apr 17, 2023
Contributor
gramalingam
left a comment
There was a problem hiding this comment.
Minor nit: I guess the "doc" string can be shared by old and new defs since they are identical by moving it to utils.h/utils.cc. And renaming it to something appropriate like Reshape_ver14_and_ver19_doc. Helps when somebody is browsing the code.
jcwchen
approved these changes
Apr 17, 2023
Member
jcwchen
left a comment
There was a problem hiding this comment.
cc release manager @yuanyao-nv
Contributor
Author
|
I suggest keeping it that way for this release and let us take time to think about a mechanism to avoid duplication in documentation. |
Member
P.S. Tracked by this #4138. |
yuanyao-nv
pushed a commit
to yuanyao-nv/onnx
that referenced
this pull request
Apr 26, 2023
Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
yuanyao-nv
pushed a commit
that referenced
this pull request
Apr 26, 2023
Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a wrong renaming introduced in PR #5123. Float 8 types were missing from Reshape allowed types.