docs: replace references to Skypack CDN with esm.sh#317
Merged
Conversation
a5ef7aa to
23580fe
Compare
kfcampbell
approved these changes
Jun 14, 2023
Contributor
|
🎉 This PR is included in version 19.0.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 20.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
stestagg
added a commit
to stestagg/rest.js
that referenced
this pull request
Aug 2, 2023
The docs at https://octokit.github.io/rest.js/v19 recommend using skypack to load this library in a browser. But this package does not load, logging a build error to the console when you try. This change updates the examples to use esm.sh. Related: octokit#317 updated the top-level readme to replace skypack with esm.sh octokit#327 was closed indicating that skypack isn't maintained any more.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Skypack CDN is no longer maintained, so we should remove references to it.