Skip to content

Support JIT plugin version wildcards#1287

Merged
jfeingold35 merged 1 commit intooclif:mainfrom
bailey-coding:patch-1
Mar 6, 2026
Merged

Support JIT plugin version wildcards#1287
jfeingold35 merged 1 commit intooclif:mainfrom
bailey-coding:patch-1

Conversation

@bailey-coding
Copy link
Copy Markdown
Contributor

Closes #1286

@salesforce-cla
Copy link
Copy Markdown

salesforce-cla Bot commented Mar 2, 2026

Thanks for the contribution! Before we can merge this, we need @bailey-coding to sign the Salesforce Inc. Contributor License Agreement.

@bailey-coding
Copy link
Copy Markdown
Contributor Author

I signed it

@jfeingold35
Copy link
Copy Markdown
Contributor

@bailey-coding , I'll get this reviewed shortly, and we'll make sure you're credited.

@bailey-coding
Copy link
Copy Markdown
Contributor Author

@bailey-coding , I'll get this reviewed shortly, and we'll make sure you're credited.

I don't mind too much about credit, but getting it reviewed, and if it makes sense approved and merged would be amazing. Thank you! 🙏

@jfeingold35
Copy link
Copy Markdown
Contributor

@bailey-coding , the PR looks solid, and I'm satisfied with my manual QA. Ideally, you could also add test coverage for the new fix, with something that used to fail and now passes thanks to the fix. Is that something you'd be able to do at this time?

@bailey-coding
Copy link
Copy Markdown
Contributor Author

Yeah, for sure. I can add some tests tomorrow

@jfeingold35
Copy link
Copy Markdown
Contributor

@bailey-coding , I'm still debugging the CLA status indicator, but I do know that if you create a new PR with the same changes after signing, then that second PR will show the CLA as having been signed.

@jfeingold35
Copy link
Copy Markdown
Contributor

@bailey-coding , alternatively, you can just close and re-open the same PR and the CLA status should update.

@bailey-coding
Copy link
Copy Markdown
Contributor Author

Great! Life got away from me a little, but working on the tests now.

@bailey-coding
Copy link
Copy Markdown
Contributor Author

Making it easier to test required changing a few more lines of code unfortunately.

@jfeingold35
Copy link
Copy Markdown
Contributor

@bailey-coding , thanks, I'll get a review and some additional QA done on this one.

@jfeingold35
Copy link
Copy Markdown
Contributor

I'm satisfied with the test coverage and with my manual QA. I've triggered an internal test run here. Once these tests pass (which I have every reason to believe they should), I'll merge the PR.
Thanks for this contribution!

@jfeingold35 jfeingold35 merged commit 6ea42ab into oclif:main Mar 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jitPlugins with version * doesn't work

2 participants