feat(runtime-utils): refactor mount + render helpers#1483
feat(runtime-utils): refactor mount + render helpers#1483
Conversation
commit: |
|
I've incorporated into my repo and checked it out. |
|
I've reverted the status to draft because I want to conduct more testing and operational verification. |
bb5c5b0 to
8b8d891
Compare
|
I have completed the intended testing and operational checks, so I have removed the draft status from the PR. |
8b8d891 to
8523c1b
Compare
|
I've reverted the status to draft because I want to conduct more testing and operational verification. |
8523c1b to
75efe57
Compare
|
I've incorporated into nuxt/ui and checked it out. One snapshot failed, but I checked it with the same settings in the playground. |
75efe57 to
3a258b9
Compare
|
I've incorporated into nuxt and checked it out. The test failed, but I think it is correct. |
|
I have updated the test-utils in the PR and re-ran the tests on the next/ui side as wel |
3a258b9 to
d0fa824
Compare
|
I've made an effort to align the behavior with vue/test-utils as much as possible. I apologize for changing the review status multiple times due to the large number of things I needed to check. Please review. Below are the links to my confirmation using the package from this PR: |
danielroe
left a comment
There was a problem hiding this comment.
thank you very much for this thorough work ❤️
|
@yamachi4416 I'm not sure how I didn't catch it, but it seems that this has caused a number of test failures upstream in nuxt/nuxt. If you have a chance, I'd welcome your review/thoughts 🙏 |
|
@danielroe |
|
@danielroe |
|
thank you so much ❤️ |
🔗 Linked issue
resolves #684, resolves #731, resolves #735, resolves #794, resolves #773, resolves #1115, resolves #1199, resolves #1205
❓ Type of change
📚 Description