fix: bring back eslint-plugin-import-x as default, close #590

antfu · antfu · commit e43d6debe7d5 · 2025-07-18T09:03:37.000+09:00
diff --git a/docs/package.json b/docs/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nuxt-eslint-docs",
-  "packageManager": "pnpm@10.12.4",
+  "packageManager": "pnpm@10.13.1",
   "private": true,
   "scripts": {
     "docs:dev": "nuxi dev",
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "private": true,
   "type": "module",
-  "packageManager": "pnpm@10.12.4",
+  "packageManager": "pnpm@10.13.1",
   "version": "1.5.2",
   "scripts": {
     "build": "pnpm run -r build",
diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -36,15 +36,11 @@
   },
   "peerDependencies": {
     "eslint": "^9.0.0",
-    "eslint-plugin-format": "*",
-    "eslint-plugin-import-x": "*"
+    "eslint-plugin-format": "*"
   },
   "peerDependenciesMeta": {
     "eslint-plugin-format": {
       "optional": true
-    },
-    "eslint-plugin-import-x": {
-      "optional": true
     }
   },
   "dependencies": {
@@ -59,6 +55,7 @@
     "eslint-flat-config-utils": "catalog:prod",
     "eslint-merge-processors": "catalog:prod",
     "eslint-plugin-import-lite": "catalog:prod",
+    "eslint-plugin-import-x": "catalog:prod",
     "eslint-plugin-jsdoc": "catalog:prod",
     "eslint-plugin-regexp": "catalog:prod",
     "eslint-plugin-unicorn": "catalog:prod",
diff --git a/packages/eslint-config/src/configs/import.ts b/packages/eslint-config/src/configs/import.ts
@@ -1,4 +1,3 @@
-import pluginImportLite from 'eslint-plugin-import-lite'
 import type { Linter } from 'eslint'
 import type { NuxtESLintConfigOptions } from '../types'
 import { resolveOptions } from '../utils'
@@ -15,9 +14,9 @@ export default async function imports(options: NuxtESLintConfigOptions): Promise
     : resolved.features.import || {}
 
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  const plugin: any = importOptions.package === 'eslint-plugin-import-x'
-    ? (await import('eslint-plugin-import-x')).default
-    : pluginImportLite
+  const plugin: any = importOptions.package === 'eslint-plugin-import-lite'
+    ? (await import('eslint-plugin-import-lite')).default
+    : (await import('eslint-plugin-import-x')).default
 
   return [
     {
@@ -26,7 +25,11 @@ export default async function imports(options: NuxtESLintConfigOptions): Promise
         import: plugin,
       },
       rules: {
-        'import/consistent-type-specifier-style': ['error', 'top-level'],
+        ...(importOptions.package === 'eslint-plugin-import-lite'
+          ? {
+              'import/consistent-type-specifier-style': ['error', 'top-level'],
+            }
+          : {}),
         'import/first': 'error',
         'import/no-duplicates': 'error',
         'import/no-mutable-exports': 'error',
diff --git a/packages/eslint-config/src/types.ts b/packages/eslint-config/src/types.ts
@@ -102,10 +102,7 @@ export interface ImportPluginOptions {
   /**
    * The import plugin to use
    *
-   * We did not ship `eslint-plugin-import-x` as dependency,
-   * if you want to use it, you need to install it manually.
-   *
-   * @default 'eslint-plugin-import-lite'
+   * @default 'eslint-plugin-import-x'
    */
   package?: 'eslint-plugin-import-lite' | 'eslint-plugin-import-x'
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "nuxt-eslint-docs",`
`3`		`- "packageManager": "pnpm@10.12.4",`
	`3`	`+ "packageManager": "pnpm@10.13.1",`
`4`	`4`	`"private": true,`
`5`	`5`	`"scripts": {`
`6`	`6`	`"docs:dev": "nuxi dev",`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"private": true,`
`3`	`3`	`"type": "module",`
`4`		`- "packageManager": "pnpm@10.12.4",`
	`4`	`+ "packageManager": "pnpm@10.13.1",`
`5`	`5`	`"version": "1.5.2",`
`6`	`6`	`"scripts": {`
`7`	`7`	`"build": "pnpm run -r build",`
Original file line number	Diff line number	Diff line change
`@@ -102,10 +102,7 @@ export interface ImportPluginOptions {`
`102`	`102`	`/**`
`103`	`103`	`* The import plugin to use`
`104`	`104`	`*`
`105`		- * We did not ship `eslint-plugin-import-x` as dependency,
`106`		`- * if you want to use it, you need to install it manually.`
`107`		`- *`
`108`		`- * @default 'eslint-plugin-import-lite'`
	`105`	`+ * @default 'eslint-plugin-import-x'`
`109`	`106`	`*/`
`110`	`107`	`package?: 'eslint-plugin-import-lite' \| 'eslint-plugin-import-x'`
`111`	`108`	`}`