BUG: fix type issues in uses if PyDataType macros#30957
Merged
charris merged 2 commits intonumpy:maintenance/2.4.xfrom Mar 7, 2026
Merged
BUG: fix type issues in uses if PyDataType macros#30957charris merged 2 commits intonumpy:maintenance/2.4.xfrom
charris merged 2 commits intonumpy:maintenance/2.4.xfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Thanks @plim for the heads up. I can't actually see what versions of numpy and cython are getting installed, cibuildwheel is swallowing the stdout in those jobs. For others: the failure is in the cython |
Contributor
|
Sorry for the noise, I think it was on our end after all (https://github.com/astropy/astropy/pull/19429/changes). |
Contributor
|
Oh actually, I see cython/cython#7576 now. Well, I am glad upstream is fixing it anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #30918.
@kumaraditya303 and I ran into these working on support for the opaque PyObject build.
These
PyDataTypemacros expect aPyArray_Descr *argument, but in all three cases happen to work because the macros use direct struct field accesses and all these structs share field names.