BUG: Fix searchsorted and CheckFromAny byte-swapping logic#28435
Merged
charris merged 1 commit intonumpy:maintenance/2.2.xfrom Mar 6, 2025
Merged
BUG: Fix searchsorted and CheckFromAny byte-swapping logic#28435charris merged 1 commit intonumpy:maintenance/2.2.xfrom
charris merged 1 commit intonumpy:maintenance/2.2.xfrom
Conversation
* BUG: Fix searchsorted and CheckFromAny byte-swapping logic This closes numpygh-28190 and fixes another issue in the initial code that triggered the regression. Note that we may still want to avoid this, since this does lead to constructing (view compatible) structured dtypes unnecessarily here. It would also compactify the dtype. For building unnecessary dtypes, the better solution may be to just introduce a "canonical" flag to the dtypes (now that we have the space). * STY: Adopt code comment suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28418.
This closes gh-28190 and fixes another issue in the initial code that triggered the regression.
Note that we may still want to avoid this, since this does lead to constructing (view compatible) structured dtypes unnecessarily here.
It would also compactify the dtype. For building unnecessary dtypes, the better solution may be to just introduce a "canonical" flag to the dtypes (now that we have the space).