Skip to content

BUG: numpy.loadtxt reads only 50000 lines when skip_rows >= max_rows#28379

Merged
charris merged 1 commit intonumpy:maintenance/2.2.xfrom
charris:backport-28319
Feb 21, 2025
Merged

BUG: numpy.loadtxt reads only 50000 lines when skip_rows >= max_rows#28379
charris merged 1 commit intonumpy:maintenance/2.2.xfrom
charris:backport-28319

Conversation

@charris
Copy link
Copy Markdown
Member

@charris charris commented Feb 21, 2025

Backport of #28319

  • fixed bug in function _read in numpy/lib/_npyio_impl.py, misnamed variable skiplines as skiprows; added test in numpy/lib/tests/test_loadtxt.py

  • fixed sintax in test_loadtxt.py

  • changed use of mkstemp with use of tmpdir provided by pytest

  • fixed bug in use of tmpdir in loadtxt test

  • Update numpy/lib/tests/test_loadtxt.py

  • Update file numpy/lib/tests/test_loadtxt.py

  • Update file numpy/lib/tests/test_loadtxt.py

  • Update numpy/lib/tests/test_loadtxt.py

…umpy#28319)

* fixed bug in function _read in numpy/lib/_npyio_impl.py, misnamed variable skiplines as skiprows; added test in numpy/lib/tests/test_loadtxt.py

* fixed sintax in test_loadtxt.py

* changed use of mkstemp with use of tmpdir provided by pytest

* fixed bug in use of tmpdir in loadtxt test

* Update numpy/lib/tests/test_loadtxt.py

Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>

* Update file numpy/lib/tests/test_loadtxt.py

* Update file numpy/lib/tests/test_loadtxt.py

* Update numpy/lib/tests/test_loadtxt.py

---------

Co-authored-by: Sebastian Berg <sebastian@sipsolutions.net>
@charris charris added 00 - Bug 08 - Backport Used to tag backport PRs labels Feb 21, 2025
@charris charris added this to the 2.2.4 release milestone Feb 21, 2025
@charris charris merged commit d3deb87 into numpy:maintenance/2.2.x Feb 21, 2025
69 of 70 checks passed
@charris charris deleted the backport-28319 branch February 21, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

00 - Bug 08 - Backport Used to tag backport PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants