BUG: Ignore invalid and overflow warnings in masked setitem#23634
Merged
charris merged 1 commit intonumpy:maintenance/1.24.xfrom Apr 22, 2023
Merged
BUG: Ignore invalid and overflow warnings in masked setitem#23634charris merged 1 commit intonumpy:maintenance/1.24.xfrom
charris merged 1 commit intonumpy:maintenance/1.24.xfrom
Conversation
Giving a warning for invalid/overflow in settitem/casts is right (IMO), however for masked arrays it can be surprising since the warning is not useful if the value is invalid but also masked. So, simply blanket ignore the relevant warnings in setitem via errstate. (There may be some other cases like `.astype()` where it might be helpful to MA users to just blanket opt-out of these new warnings.) Closes numpygh-23000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23627.
Giving a warning for invalid/overflow in settitem/casts is right (IMO), however for masked arrays it can be surprising since the warning is not useful if the value is invalid but also masked.
So, simply blanket ignore the relevant warnings in setitem via errstate. (There may be some other cases like
.astype()where it might be helpful to MA users to just blanket opt-out of these new warnings.)Closes gh-23000