BUG: Ensure like is only stripped for like= dispatched functions#23370
Merged
charris merged 1 commit intonumpy:maintenance/1.24.xfrom Mar 10, 2023
Merged
BUG: Ensure like is only stripped for like= dispatched functions#23370charris merged 1 commit intonumpy:maintenance/1.24.xfrom
like= dispatched functions#23370charris merged 1 commit intonumpy:maintenance/1.24.xfrom
Conversation
This issue is already fixed differently on the main (1.25) branch, an alternative might be to check for functions with **kwargs, there seem to be three: savez, savez_compressed, and apply_along_axes.
Contributor
|
Provided tests pass, this looks sensible to me. Thanks Sebastian! |
pentschev
approved these changes
Mar 10, 2023
Contributor
pentschev
left a comment
There was a problem hiding this comment.
Relevant Dask tests seem to pass with this PR as well, so definitely seems good to me.
Member
|
Thanks Sebastian. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue is already fixed differently on the main (1.25) branch,
an alternative might be to check for functions with **kwargs, there seem
to be three: savez, savez_compressed, and apply_along_axes.
Closes gh-23365
After some back and forth, this seemed like the easiest approach after all. @pentschev what do you think?