Skip to content

MAINT: Don't use vulture 2.15, it has false positives#30958

Merged
charris merged 1 commit intonumpy:maintenance/2.4.xfrom
charris:backport-30938
Mar 7, 2026
Merged

MAINT: Don't use vulture 2.15, it has false positives#30958
charris merged 1 commit intonumpy:maintenance/2.4.xfrom
charris:backport-30938

Conversation

@charris
Copy link
Copy Markdown
Member

@charris charris commented Mar 7, 2026

Backport of #30938.

CI is failing due to the update, I opened an issue there, this just blocks the broken version.

The CI failures look like:

numpy/_build_utils/tempita/_tempita.py:1031: unreachable code after 'while' (100% confidence)
numpy/f2py/_src_pyf.py:80: unreachable code after 'while' (100% confidence)
numpy/f2py/crackfortran.py:546: unreachable code after 'while' (100% confidence)
numpy/lib/_utils_impl.py:188: unreachable code after 'while' (100% confidence)
numpy/linalg/lapack_lite/make_lite.py:174: unreachable code after 'while' (100% confidence)

all of those are while True loops with perfectly fine break conditionals.

@charris charris added this to the 2.4.3 release milestone Mar 7, 2026
@charris charris added 03 - Maintenance 08 - Backport Used to tag backport PRs labels Mar 7, 2026
@charris charris merged commit f302a16 into numpy:maintenance/2.4.x Mar 7, 2026
72 checks passed
@charris charris deleted the backport-30938 branch March 7, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

03 - Maintenance 08 - Backport Used to tag backport PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants