MAINT: Avoid dereferencing/strict aliasing warnings#28915
Merged
charris merged 1 commit intonumpy:maintenance/2.2.xfrom May 6, 2025
Merged
MAINT: Avoid dereferencing/strict aliasing warnings#28915charris merged 1 commit intonumpy:maintenance/2.2.xfrom
charris merged 1 commit intonumpy:maintenance/2.2.xfrom
Conversation
…sts in `npy_math.h` for C++ runs (numpy#28892) * MAINT: Avoid type-punning complex casts in npy_math.h * MAINT: Add missing typecast in npy_cimagl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28892.
Happens in
npy_math.hduring complex casts in for C++ runsI am aware that this file went through many iterations and complex support is a constant headache, and if there is any more appetite left, I'd like to offer another minor change.
We have been having some warnings coming from non-C99-compliant compilers and C++ runs over SciPy since NumPy 2.0. This is mainly due to the
npy_crealX/npy_cimagXfunctions, casting the inputstructfirst and then dereferencing it in the new type, causing the strict-aliasing (type punning) rule to fire.Here is a recent example how this manifests itself in the build process https://github.com/scipy/scipy/actions/runs/14770722795/job/41470198162#step:6:300
I don't know if the SciPy code is also commiting some C++ sins but the NumPy code can do better to avoid strange bugs. I don't claim to have the right solution but seems like the most obvious one to me to let the compiler handle the possible padding/endianness issues with a straight struct field access. However I don't have a strong opinion since I'm not a C++ expert.
This is also somewhat related to our ambition to be warning free at some point.
MAINT: Avoid type-punning complex casts in npy_math.h
MAINT: Add missing typecast in npy_cimagl