Merged
Conversation
ngoldbaum
commented
Jan 27, 2025
Member
|
Should we backport this? |
Contributor
|
Nice - thanks! - with the fix at #28235, this allows the Numpy build to work without failure on WoA, with |
Member
Author
|
I think this should be safe to backport. |
Member
|
Thanks Nathan. |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Jan 27, 2025
* BUG: add C++ support to npy_atomic.h * MAINT: delete outdated comment
charris
added a commit
that referenced
this pull request
Jan 27, 2025
BUG: Add cpp atomic support (#28234)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28106
This builds and passes the test on my Mac but let's see what the full CI says.
The code I'm adding is cribbed from CPython's
pyatomic.handpyatomic_std.h.