fix(nextjs): reset daemon client after project graph creation in withNx#34518
Merged
FrozenPandaz merged 1 commit intomasterfrom Feb 20, 2026
Merged
fix(nextjs): reset daemon client after project graph creation in withNx#34518FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
Contributor
|
View your CI Pipeline Execution ↗ for commit 0801a4b
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
Our investigation shows this test failure is pre-existing in the master branch and unrelated to the daemon client reset changes. The error stems from a missing ESM submodule in @microsoft/api-extractor during Vite config processing, which has no connection to the Next.js withNx modifications in this PR.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
## Current Behavior Running `nx test` for Next.js projects causes Jest to hang with: "Jest did not exit one second after the test run has completed." This happens because `next/jest` loads `next.config.js`, which calls `withNx` → `createProjectGraphAsync()`. The daemon client socket connection is left open, keeping the Node.js event loop alive and preventing Jest from exiting. ## Expected Behavior Jest exits cleanly after tests complete for Next.js projects. ## Related Issue(s) Fixes #32880
Member
|
This should be fixed after #34506, I don't think this ones needed? |
Member
Author
Hmm, will test after that change lands. |
FrozenPandaz
approved these changes
Feb 20, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 20, 2026
…Nx (#34518) ## Current Behavior Running `nx test` for Next.js projects causes Jest to hang with: ``` Jest did not exit one second after the test run has completed. ``` This happens because `next/jest` loads `next.config.js`, which calls `withNx` → `createProjectGraphAsync()`. The daemon client socket connection is left open, keeping the Node.js event loop alive and preventing Jest from exiting. Non-Next.js projects are unaffected since they don't trigger this code path. ## Expected Behavior Jest exits cleanly after tests complete for Next.js projects, without needing `forceExit: true`. ## Fix Pass `resetDaemonClient: true` to `createProjectGraphAsync()` in `packages/next/plugins/with-nx.ts`. This tells the project graph function to call `daemonClient.reset()` after fetching the graph, which closes the socket and allows Jest to exit. ### Verification | Scenario | Before | After | |----------|--------|-------| | `nx test next-app` | Hangs | Exits cleanly | | `NX_DAEMON=false nx test next-app` | Exits cleanly | Exits cleanly | | Direct `npx jest` | Exits cleanly | Exits cleanly | | Non-Next.js `nx test react-lib` | Exits cleanly | Exits cleanly | ## Related Issue(s) Fixes #32880 (cherry picked from commit de2dc7c)
llwt
pushed a commit
that referenced
this pull request
Feb 23, 2026
…Nx (#34518) ## Current Behavior Running `nx test` for Next.js projects causes Jest to hang with: ``` Jest did not exit one second after the test run has completed. ``` This happens because `next/jest` loads `next.config.js`, which calls `withNx` → `createProjectGraphAsync()`. The daemon client socket connection is left open, keeping the Node.js event loop alive and preventing Jest from exiting. Non-Next.js projects are unaffected since they don't trigger this code path. ## Expected Behavior Jest exits cleanly after tests complete for Next.js projects, without needing `forceExit: true`. ## Fix Pass `resetDaemonClient: true` to `createProjectGraphAsync()` in `packages/next/plugins/with-nx.ts`. This tells the project graph function to call `daemonClient.reset()` after fetching the graph, which closes the socket and allows Jest to exit. ### Verification | Scenario | Before | After | |----------|--------|-------| | `nx test next-app` | Hangs | Exits cleanly | | `NX_DAEMON=false nx test next-app` | Exits cleanly | Exits cleanly | | Direct `npx jest` | Exits cleanly | Exits cleanly | | Non-Next.js `nx test react-lib` | Exits cleanly | Exits cleanly | ## Related Issue(s) Fixes #32880
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running
nx testfor Next.js projects causes Jest to hang with:This happens because
next/jestloadsnext.config.js, which callswithNx→createProjectGraphAsync(). The daemon client socket connection is left open, keeping the Node.js event loop alive and preventing Jest from exiting. Non-Next.js projects are unaffected since they don't trigger this code path.Expected Behavior
Jest exits cleanly after tests complete for Next.js projects, without needing
forceExit: true.Fix
Pass
resetDaemonClient: truetocreateProjectGraphAsync()inpackages/next/plugins/with-nx.ts. This tells the project graph function to calldaemonClient.reset()after fetching the graph, which closes the socket and allows Jest to exit.Verification
nx test next-appNX_DAEMON=false nx test next-appnpx jestnx test react-libRelated Issue(s)
Fixes #32880