fix(core): avoid dropping unrelated continuous deps in makeAcyclic#34389
Merged
FrozenPandaz merged 1 commit intomasterfrom Feb 10, 2026
Merged
fix(core): avoid dropping unrelated continuous deps in makeAcyclic#34389FrozenPandaz merged 1 commit intomasterfrom
makeAcyclic#34389FrozenPandaz merged 1 commit intomasterfrom
Conversation
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit f7f99a7
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Feb 10, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 13, 2026
…34389) ## Current Behavior Cycles in the task graph could remove unrelated `continuousDependencies` when the cycle exists only in `dependencies`, leading to missing continuous task edges. ## Expected Behavior Cycle removal only removes the specific cyclic edge from the list where it appears, preserving unrelated continuous dependencies. (cherry picked from commit 6c9f0cb)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Cycles in the task graph could remove unrelated
continuousDependencieswhen the cycle exists only independencies, leading to missing continuous task edges.Expected Behavior
Cycle removal only removes the specific cyclic edge from the list where it appears, preserving unrelated continuous dependencies.