fix(core): allow overriding daemon logging settings#34324
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
❌ Deploy Preview for nx-dev failed. Why did it fail? →
|
|
View your CI Pipeline Execution ↗ for commit d3df235
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
These changes fix the failing e2e-gradle test by removing NX_NATIVE_LOGGING from the allowed environment variables in e2e tests. The PR's changes to make daemon logging overridable were causing Gradle plugin warnings to appear in test output when NX_NATIVE_LOGGING was passed through from the test environment, failing the test assertion.
Tip
✅ We verified this fix by re-running e2e-gradle:e2e-ci--src/gradle.test.ts.
diff --git a/e2e/utils/get-env-info.ts b/e2e/utils/get-env-info.ts
index 27b0367187..73eb46b785 100644
--- a/e2e/utils/get-env-info.ts
+++ b/e2e/utils/get-env-info.ts
@@ -151,7 +151,9 @@ export function getStrippedEnvironmentVariables() {
'NX_ADD_PLUGINS',
'NX_ISOLATE_PLUGINS',
'NX_VERBOSE_LOGGING',
- 'NX_NATIVE_LOGGING',
+ // NX_NATIVE_LOGGING is intentionally excluded to prevent e2e tests from
+ // overriding daemon logging settings, which can cause test failures when
+ // warnings/debug output appears in command results
];
if (key.startsWith('NX_') && !allowedKeys.includes(key)) {
Or Apply changes locally with:
npx nx-cloud apply-locally EQKR-BCqJ
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
1b3309d to
d3df235
Compare
## Current Behavior NX_NATIVE_LOGGING is hardcoded and can't be customized on the daemon server ## Expected Behavior Log settings can be customized by changing them in the env of the first command to spawn the daemon ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
## Current Behavior NX_NATIVE_LOGGING is hardcoded and can't be customized on the daemon server ## Expected Behavior Log settings can be customized by changing them in the env of the first command to spawn the daemon ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 82265ff)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
NX_NATIVE_LOGGING is hardcoded and can't be customized on the daemon server
Expected Behavior
Log settings can be customized by changing them in the env of the first command to spawn the daemon
Related Issue(s)
Fixes #