fix(core): disable ignore filters for outputs expansion#34316
fix(core): disable ignore filters for outputs expansion#34316FrozenPandaz merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 3ae6dd3
☁️ Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
92d3485 to
a840d93
Compare
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We added .gradle to the list of always-ignored directories in the file walker to fix the Gradle e2e test failure. The PR's change to disable standard filters for output expansion was allowing the walker to enter .gradle/ directories, which interfered with Gradle daemon lock files and caused the daemon to shut down with "stop command received" errors.
Warning
❌ We could not verify this fix.
diff --git a/packages/nx/src/native/walker.rs b/packages/nx/src/native/walker.rs
index f73cfa158f..ffdd6af4b1 100644
--- a/packages/nx/src/native/walker.rs
+++ b/packages/nx/src/native/walker.rs
@@ -170,6 +170,7 @@ where
"**/.nx/cache",
"**/.nx/workspace-data",
"**/.yarn/cache",
+ "**/.gradle",
])
.expect("These static ignores always build");
Or Apply changes locally with:
npx nx-cloud apply-locally Jya8-84eH
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
a840d93 to
3ae6dd3
Compare
## Current Behavior When a task output directory contains a nested `.gitignore` that hides its contents, Nx can treat the outputs as already present and skip restoring them from cache. This can result in generated files being missing from disk, even though the cache entry is valid. ## Expected Behavior Nx should restore cached outputs regardless of ignore rules inside the output directory. ## Related Issue(s) Fixes #32620 (cherry picked from commit dffdfa6)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When a task output directory contains a nested
.gitignorethat hides its contents, Nx can treat the outputs as already present and skip restoring them from cache. This can result in generated files being missing from disk, even though the cache entry is valid.Expected Behavior
Nx should restore cached outputs regardless of ignore rules inside the output directory.
Related Issue(s)
Fixes #32620