fix(core): remove shellapi from winapi featureset to minimize AV false positives#34208
Merged
AgentEnder merged 3 commits intomasterfrom Feb 13, 2026
Merged
fix(core): remove shellapi from winapi featureset to minimize AV false positives#34208AgentEnder merged 3 commits intomasterfrom
AgentEnder merged 3 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 186e55c
☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🎓 Learn more about Self-Healing CI on nx.dev
6ffc7ec to
619c782
Compare
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx create-nx-workspace@22.5.0-pr.34208.619c782 my-workspaceOr just copy this version and use it in your own command: 22.5.0-pr.34208.619c782
To request a new release for this pull request, mention someone from the Nx team or the |
…e positives [Self-Healing CI Rerun]
619c782 to
6a66c2d
Compare
AgentEnder
commented
Feb 12, 2026
| res.set("ProductName", "Nx Build System") | ||
| .set( | ||
| "FileDescription", | ||
| "Nx Native Module - High-performance build system operations", |
Member
Author
There was a problem hiding this comment.
Suggested change
| "Nx Native Module - High-performance build system operations", | |
| "The Monorepo Platform that amplifies both developers and AI agents. Nx optimizes your builds, scales your CI, and fixes failed PRs automatically. Ship in half the time.", |
AgentEnder
commented
Feb 12, 2026
AgentEnder
commented
Feb 12, 2026
| "Nx Native Module - High-performance build system operations", | ||
| ) | ||
| .set("CompanyName", "Nrwl") | ||
| .set("LegalCopyright", "Copyright (c) Nrwl. MIT License.") |
Member
Author
There was a problem hiding this comment.
Suggested change
| .set("LegalCopyright", "Copyright (c) Nrwl. MIT License.") | |
| .set("LegalCopyright", "Copyright (c) Narwhal Technologies Inc. MIT License.") |
FrozenPandaz
approved these changes
Feb 12, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 13, 2026
…e positives (#34208) ## Current Behavior There's a chance that windows can falsely flag our native binaries as a threat. We do not use the shellapi feature from winapi. ## Expected Behavior We hope that removing this API doesn't break things, and the threat messaging goes away ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes ##34186 --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 13, 2026
…e positives (#34208) ## Current Behavior There's a chance that windows can falsely flag our native binaries as a threat. We do not use the shellapi feature from winapi. ## Expected Behavior We hope that removing this API doesn't break things, and the threat messaging goes away ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes ##34186 --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> (cherry picked from commit ece9b5b)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
There's a chance that windows can falsely flag our native binaries as a threat. We do not use the shellapi feature from winapi.
Expected Behavior
We hope that removing this API doesn't break things, and the threat messaging goes away
Related Issue(s)
Fixes ##34186