fix(core): clean up daemon workspace data directory on nx reset --onl…#34174
fix(core): clean up daemon workspace data directory on nx reset --onl…#34174
Conversation
…yDaemon Previously, `nx reset --onlyDaemon` would only stop the daemon process but not clean up the daemon files in `.nx/workspace-data/d`. This change ensures the daemon workspace data directory is also removed when using the `--onlyDaemon` flag, consistent with the behavior of a full reset.
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit 1bf0291
☁️ Nx Cloud last updated this comment at |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: MaxKless <MaxKless@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
Our analysis indicates these failures are due to an environment_state issue rather than the PR's code changes. All 79 failing tasks show ERR_PNPM_WORKSPACE_PKG_NOT_FOUND for @jsonjoy.com/fs-core@workspace:*, which is a pnpm workspace configuration problem unrelated to the daemon reset cleanup functionality being modified in this PR.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Previously,
nx reset --onlyDaemonwould only stop the daemon process but not clean up the daemon files in.nx/workspace-data/d. This change ensures the daemon workspace data directory is also removed when using the--onlyDaemonflag, consistent with the behavior of a full reset.