fix(schematics): add appRoot.path for filesystem reads/writes to run linter from any directory#341
Merged
vsavkin merged 1 commit intonrwl:masterfrom Mar 25, 2018
Merged
Conversation
skydever
added a commit
to skydever/nx-quick-fixes
that referenced
this pull request
Mar 19, 2018
skydever
added a commit
to skydever/nx-quick-fixes
that referenced
this pull request
Mar 19, 2018
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am running my ide (vscode) not from the root of the nx workspace, the nx workspace is a sub-directory of the main directory I open (with vscode). This way the linter is also not running from the root directory of the nx workspace, like mentioned at 545f2ff.
There were some changes made to the
nxEnforceModuleBoundariesRulethat broke the behaviour of 545f2ff. The ide is not able to show the lint errors anymore, but runningng lintis. This PR should allow the ide to also show the lint errors even if the nx workspace is not the main directory.