Skip to content

feat(angular): add migration to set isolateModules: true to jest tsconfig files#33889

Merged
leosvelperez merged 1 commit intomasterfrom
angular/migration-for-jest-isolated-modules
Dec 16, 2025
Merged

feat(angular): add migration to set isolateModules: true to jest tsconfig files#33889
leosvelperez merged 1 commit intomasterfrom
angular/migration-for-jest-isolated-modules

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

Current Behavior

When upgrading to Angular 21 with Jest, users may encounter TypeScript compilation issues because their tsconfig.spec.json files don't have isolatedModules: true set, which is required for compatibility with Jest and jest-preset-angular.

Expected Behavior

After running nx migrate, Angular projects using Jest will automatically have isolatedModules: true added to their tsconfig.spec.json files (or custom test tsconfig files referenced by @nx/jest:jest tasks) if not already set or inherited from a parent tsconfig.

@leosvelperez leosvelperez self-assigned this Dec 16, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner December 16, 2025 18:05
@leosvelperez leosvelperez requested a review from Coly010 December 16, 2025 18:05
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Dec 16, 2025 6:10pm

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 16, 2025

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 058b9c7
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69419f6ff1a8b00008a410f9
😎 Deploy Preview https://deploy-preview-33889--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Dec 16, 2025

View your CI Pipeline Execution ↗ for commit 058b9c7

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 14m 57s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 24s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-16 18:25:51 UTC

@leosvelperez leosvelperez merged commit 71bfc21 into master Dec 16, 2025
20 checks passed
@leosvelperez leosvelperez deleted the angular/migration-for-jest-isolated-modules branch December 16, 2025 18:30
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants